Skip to content

Navigation: Share submenu icon code#75915

Closed
scruffian wants to merge 1 commit intotrunkfrom
share/submenu-icon-code
Closed

Navigation: Share submenu icon code#75915
scruffian wants to merge 1 commit intotrunkfrom
share/submenu-icon-code

Conversation

@scruffian
Copy link
Contributor

What?

Share the submenu icon code between the navigation link and submenu block.

Why?

We should share duplicated code to help with maintenance.

How?

Move the shared code to the navigation-link/shared directory.

Testing Instructions

  1. Add a navigation block with submenus
  2. Open the frontend of the site
  3. Confirm that there are icons by the submenus on the navigation block.

@scruffian scruffian self-assigned this Feb 25, 2026
@scruffian scruffian added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Feb 25, 2026
@github-actions github-actions bot added the [Package] Block library /packages/block-library label Feb 25, 2026
@scruffian scruffian added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 25, 2026
@scruffian scruffian closed this Feb 25, 2026
@github-actions
Copy link

Flaky tests detected in d47968e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22403903731
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant