Clarify WP_Error handling safety for rest_post_dispatch type hint

[Copilot]

A review comment on #76327 suggested loosening the WP_REST_Response $response type hint on _gutenberg_connectors_rest_settings_dispatch, claiming rest_post_dispatch could receive a WP_Error and cause a fatal TypeError. This PR investigates and responds to that concern.

Finding

The concern is unfounded. WordPress core's serve_request explicitly converts any WP_Error to WP_REST_Response via error_to_response() before invoking rest_post_dispatch:

// ...then convert WP_Error across.
if ( is_wp_error( $result ) ) {
    $result = $this->error_to_response( $result );
}
$result = apply_filters( 'rest_post_dispatch', rest_ensure_response( $result ), $this, $request );

The WP_REST_Response $response type hint is accurate and safe — no code changes are required.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.