Skip to content

Fix Dots style Separator in Twenty Twenty, adding charset and alternative text#10957

Open
sabernhardt wants to merge 7 commits intoWordPress:trunkfrom
sabernhardt:t20-separator-dots
Open

Fix Dots style Separator in Twenty Twenty, adding charset and alternative text#10957
sabernhardt wants to merge 7 commits intoWordPress:trunkfrom
sabernhardt:t20-separator-dots

Conversation

@sabernhardt
Copy link

  1. Adds the dots content property and auto height in the theme, with the same selectors they had in block-library styles before WordPress 6.6.
  2. Assigns UTF-8 charset to make sure CSS content displays correctly even if the site uses a different character set.
  3. Adds alternative text syntax for each content property that is not already empty or none, and leaves the original content property as a fallback for older browsers.
    • dots in the Separator block
    • quotation mark in the Pullquote block
    • em dash in the RSS widget
    • SVG for checkboxes

Props umeshsinghin, narenin

Trac 61787


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props umeshsinghin, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants