Skip to content

Removed unnecessary leading space at class in wp-login.php#10983

Closed
OpuRockey wants to merge 1 commit intoWordPress:trunkfrom
OpuRockey:fix/unnecessary-leading-spaces-at-class
Closed

Removed unnecessary leading space at class in wp-login.php#10983
OpuRockey wants to merge 1 commit intoWordPress:trunkfrom
OpuRockey:fix/unnecessary-leading-spaces-at-class

Conversation

@OpuRockey
Copy link

@OpuRockey OpuRockey commented Feb 19, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64673

Description

There is an unnecessary leading space in the class attribute construction on line 187 of wp-login.php.
The class string is generated using:

implode( ' ', $classes )

Since implode( ' ', $classes ) in line 201 already inserts a space between each class name, adding an additional leading space before the output results in a double space in the rendered class attribute.

Expected Behavior

The class attribute should not contain a leading space. The extra space should be removed to ensure clean and consistent markup.

Proposed Fix

Remove the unnecessary leading space before the implode() output so that spacing is handled solely by implode( ' ', $classes ).

Impact

  1. Minor markup cleanup
  2. Improves code quality and consistency
  3. Prevents unintended formatting inconsistencies

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props opurockey.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61775
GitHub commit: 0d52263

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant