Soft wrap the Media Title field in media modal: For better readabilit…#4516
Open
mrinal013 wants to merge 19 commits intoWordPress:trunkfrom
Open
Soft wrap the Media Title field in media modal: For better readabilit…#4516mrinal013 wants to merge 19 commits intoWordPress:trunkfrom
mrinal013 wants to merge 19 commits intoWordPress:trunkfrom
Conversation
…y/editing of long titles.
porg
reviewed
May 29, 2023
porg
left a comment
There was a problem hiding this comment.
Hi, thanks for taking action!
If you read the corresponding ticket, the text field should be edit-able and guaranteed to get not line breaks.
Does your patch achieve both?
|
B/c if it is a standard HTML textarea then the user can (un)intentionally insert line breaks. Is your patch avoiding linebreaks client or server side? |
Author
|
Hello @porg, |
Author
|
Hello @porg , Now these changes have been able to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soft wrap the Media Title field in media modal: For better readability/editing of long titles.
Trac ticket: 58416
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.