Skip to content

Soft wrap the Media Title field in media modal: For better readabilit…#4516

Open
mrinal013 wants to merge 19 commits intoWordPress:trunkfrom
mrinal013:58416
Open

Soft wrap the Media Title field in media modal: For better readabilit…#4516
mrinal013 wants to merge 19 commits intoWordPress:trunkfrom
mrinal013:58416

Conversation

@mrinal013
Copy link

Soft wrap the Media Title field in media modal: For better readability/editing of long titles.

Trac ticket: 58416


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

@porg porg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking action!

If you read the corresponding ticket, the text field should be edit-able and guaranteed to get not line breaks.

Does your patch achieve both?

@porg
Copy link

porg commented May 29, 2023

B/c if it is a standard HTML textarea then the user can (un)intentionally insert line breaks.

Is your patch avoiding linebreaks client or server side?

@mrinal013
Copy link
Author

Hello @porg,
Thanks for your hint.
Now, this change prevents (un)intentional line breaks.

@mrinal013 mrinal013 closed this May 30, 2023
@mrinal013 mrinal013 reopened this May 30, 2023
@mrinal013
Copy link
Author

Hello @porg ,

Now these changes have been able to

  1. soft-wrap the title
  2. do server-side validation if a user (un)intentionally uses a line break
  3. do server-side validation if a user (un)intentionally use any tags in the title of the attachment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants