Skip to content

Trac 64012 avoid counting post editor admin inline comments alongside user comments#9998

Open
risto987 wants to merge 2 commits intoWordPress:trunkfrom
risto987:trac-64012-avoid-counting-post-editor-admin-inline-comments-alongside-user-comments
Open

Trac 64012 avoid counting post editor admin inline comments alongside user comments#9998
risto987 wants to merge 2 commits intoWordPress:trunkfrom
risto987:trac-64012-avoid-counting-post-editor-admin-inline-comments-alongside-user-comments

Conversation

@risto987
Copy link

This PR modifies the get_pending_comments_num() function to exclude editorial comments from the pending count and makes the function more extensible.

Changes Made:

Fixed the query by excluding block_comment type.

Added extensibility: Introduced the pre_get_pending_comments_num filter hook. This allows developers to modify the query arguments used for counting, making it future-proof for custom comment types or additional filtering needs.

Trac ticket: https://core.trac.wordpress.org/ticket/64012


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…nts by modifying the query in the get_pending_comments_num() function
…bility for custom comment types or additional filtering requirements
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ristojovanovic.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant