This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Remove local_variables from on_phase_end#421
Closed
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Remove local_variables from on_phase_end#421vreis wants to merge 1 commit intofacebookresearch:masterfrom
vreis wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
Summary: This is part of a series of diffs to eliminate local_variables (see D20171981). Final step! Remove local_variables from on_phase_end. Reviewed By: mannatsingh Differential Revision: D20178293 fbshipit-source-id: c6b7a4a0ea79c8da4ac22dbb6f2e372384e77b6f
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20178293 |
Contributor
|
This pull request has been merged in 636740b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of a series of diffs to eliminate local_variables (see D20171981).
Final step! Remove local_variables from on_phase_end.
Reviewed By: mannatsingh
Differential Revision: D20178293