Validators: added isListOfType()

[dstrop]

I would like to resolve #119.

[JanTvrdik]

You either need to rename the method to isIterableOfType($value, $type) or check whether the value is a list (by calling self::isList($list))

[TomasVotruba]

I would expect this method to support objects as well:

Validators::isIterableOfType($items, Product::class);

For inspiration:

• in PHPUnit, there is assertInternalType for string/int/bools.
• in beberlei/assert is allIsInstanceOf

[dstrop]

I thought about it but decided the object should implement Travarsable if you want to iterate through its properties. As is in new php7.1 function is_iterable.

[JanTvrdik]

@TomasVotruba I think that the example you've posted should work just fine with the current implementation.

[dg]

What about everyIs?

[TomasVotruba]

@JanTvrdik Ah, that is missing in tests, that suggest only scalar types are supported.

@t0his Could you please add test for simple object check? Sth like:

test(function () {
    Assert::true(Validators::isIterableOfType([new Product], Product::class));
    Assert::false(Validators::isIterableOfType([new Product, new stdClass], Product::class));
});

[dstrop]

@TomasVotruba Sure i can add it, but shouldnt this be covered by is() tests?

@dg Ok i can rename it once i get home.

[dg]

It was only a suggestion, hold on.

[TomasVotruba]

@t0his Most part of the test is already covered by is(), but that's not the goal.
The test would be easier to understand, if both use cases - scalar and object - would be covered.

[dstrop]

@TomasVotruba Ok would you like to add some other use case?

[JanTvrdik]

Maybe extract method isIterable + support is($value, 'iterable')?

[dstrop]

But the method will soon be redundant with php7.1.

[JanTvrdik]

Yes, the method would use is_iterable and fallback to implementation in PHP in PHP < 7.1; probably best to make the method private to allow removal in future without breaking BC.

[TomasVotruba]

@t0his Nope, I guess that's all I would expect this method to do. Thank you.

[dg]

Please use simply return is_array($value) || $value instanceof \Traversable;, function_exists is unnecessary complication.