Skip to content

[3.8] bpo-42866: Fix refleak in CJK getcodec() (GH-24165)#24168

Closed
miss-islington wants to merge 1 commit intopython:3.8from
miss-islington:backport-e542d41-3.8
Closed

[3.8] bpo-42866: Fix refleak in CJK getcodec() (GH-24165)#24168
miss-islington wants to merge 1 commit intopython:3.8from
miss-islington:backport-e542d41-3.8

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 8, 2021

Fix a reference leak in the getcodec() function of CJK codecs.
(cherry picked from commit e542d41)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue42866

Fix a reference leak in the getcodec() function of CJK codecs.
(cherry picked from commit e542d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner
Copy link
Member

vstinner commented Jan 8, 2021

Oh, getmultibytecodec() holds a reference to cofunc. My backport is wrong, sorry.

@vstinner vstinner closed this Jan 8, 2021
@miss-islington miss-islington deleted the backport-e542d41-3.8 branch January 8, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants