Add a test case for false positive#419
Merged
kodiakhq[bot] merged 2 commits intorickbusarow:mainfrom Apr 9, 2022
Merged
Conversation
Member
|
Thanks for the test! I'll be getting to this very soon. |
Contributor
Author
|
Marking it as draft makes sense 😅 I actually tried to fix it. One thing that I realized is that you have a task dependency to I debugged (by putting bunch of print statements 😂) everything seems to be fine but the resources source sets somehow do not include the generated resources folder. I couldn't figure out why. |
Member
|
@dependabot recreate |
b1fe6ac to
f47195d
Compare
RBusarow
approved these changes
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was one false-positive in our project. Instead of opening an issue, I thought it would be better to have a failing test case.
If a dependant module uses
resValue, then the generated resource usage is not detected.