Support the alternative usage of kapt plugin#481
Merged
kodiakhq[bot] merged 3 commits intorickbusarow:mainfrom Apr 4, 2022
Merged
Support the alternative usage of kapt plugin#481kodiakhq[bot] merged 3 commits intorickbusarow:mainfrom
kodiakhq[bot] merged 3 commits intorickbusarow:mainfrom
Conversation
RBusarow
approved these changes
Apr 4, 2022
Member
RBusarow
left a comment
RBusarow
left a comment
There was a problem hiding this comment.
Thanks for this! And sorry for the late review...
A lot of this "unused kapt" stuff is carried over from an internal plugin which predated ModuleCheck. I'm afraid I kind of shoe-horned it into this project. One of these days I'll rewrite the whole thing.
Contributor
Author
|
No worries, it works and it doesn't have to be perfect as long as it adds value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project, the line numbers were not shown correctly. I figured out we had another was of adding kapt plugin.
FYI: All Kotlin plugins have 3 different way of applying: 2 ids and 1 function.
Btw,
@Suppressannotation also did not work for Kapt but I didn't have a chance to reproduce that. I'm hoping that this also fixes that issue.