fix(skill): correct MCP local server env key to environment in customize-opencode - #35867
Closed
NumerousJLs wants to merge 2 commits into
Closed
fix(skill): correct MCP local server env key to environment in customize-opencode#35867NumerousJLs wants to merge 2 commits into
NumerousJLs wants to merge 2 commits into
Conversation
…ize-opencode The built-in customize-opencode skill showed two example MCP local server blocks using "env" as the key for environment variables. The config schema (McpLocalConfig) and the runtime in mcp/index.ts both use "environment". Users copying these examples had their env vars silently dropped with no error, since the config loader strips unknown keys. Closes anomalyco#35860
This was referenced Jul 26, 2026
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35860
Type of change
What does this PR do?
The built-in
customize-opencodeskill showed"env"as the key for MCP local server environment variables in two example blocks. The config schema (packages/core/src/config/mcp.ts) and the runtime (packages/opencode/src/mcp/index.ts:342) both use"environment". The config loader strips unknown keys without warning, so users copying the example had their env vars silently dropped — no error, just absent subprocess environment variables.Two changes in one file:
How did you verify your code works?
bun test test/plugin/skill.test.tsfrompackages/core— 1 pass, 0 failbun run typecheck(turbo, all 30 packages) — 30 successful, 0 errors"environment"matches the field name inpackages/core/src/config/mcp.ts:12and whatmcp/index.ts:342reads at runtimeChecklist