Presenter: removed static from refUrl variable - #80
Merged
Conversation
Yrwein
force-pushed
the
remove_static_from_refUrl
branch
from
June 12, 2015 11:45
bb63d7c to
fb53532
Compare
Contributor
|
👍 I like it. But how does it affect performance in real-world apps? |
Contributor
Author
|
Frankly, I don't think there will be measurable performance hit from changing function's static variable to property. Or is there something I'm missing? (Nevertheless we can wait few weeks until it's deployed.) |
dg
force-pushed
the
master
branch
6 times, most recently
from
June 21, 2015 14:21
51b53ed to
d36f845
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
July 1, 2015 15:46
0c73a68 to
d07d7b3
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
October 2, 2015 14:25
8e097dc to
e4eb640
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 3, 2015 04:09
7f051bf to
f87df33
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
January 13, 2016 18:03
9725b1d to
9869e52
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
January 22, 2016 03:07
18f376d to
3fe619f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 8, 2016 13:39
20a93ca to
08cbdeb
Compare
dg
force-pushed
the
master
branch
11 times, most recently
from
May 5, 2016 19:22
8eb9618 to
5d63a8d
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
May 13, 2016 13:11
c7531dc to
b7a311f
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
May 20, 2016 11:42
12d577b to
e04c0e1
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 23, 2016 01:09
7b1ec30 to
3adfa43
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
June 7, 2016 10:30
c73b255 to
9e7cd60
Compare
|
Hi there:) what's the current status of this pull request? |
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request fixes issue when testing presenters without isolation: You make two presenter calls with Nette\Http\Request-s on different domains - the first domain is cached for whole class (and not only instance) and so the second instance of the same presenter will redirect you to the first domain.
The test is appended mainly as example (there's no problem to remove it if it's not needed).