Controls: element prototypes

[matej21]

CheckBoxList item label prototype:

• BC break: attributes of main label are ignored for individual item labels
• fixes consistency - radiolist already has itemLabelPrototype
• http://forum.nette.org/cs/22457-checkboxlist-a-pridani-atributu-jako-je-treba-class-nebo-data-atribut-k-jednotlivym-checkboxum-v-listu (see my comment there)

SelectBox and MultiselectBox item prototype

• BC break: no
• simplifies http://forum.nette.org/cs/22874-select-a-options-data-attributy

[dg]

I'm not sure whether it is good idea to store SelectBox item prototype as Html object. Only attributes are used, more precisely, it is not HTML attributes, it is special attributes like data-foo: (with colon).

[matej21]

I know it is not ideal. But Utils\Html api is well known and I didn't want to introduce a new api.
But I'm open to your suggestions. Maybe just use an array and setItemAttributes (or addItemAttributes)?

[dg]

Maybe setItemLabelAttribute or Attributes? Yes, it is long name, but it will be used rarely.

Probably for consistency the same method should be added to RadioList.

[matej21]

I thought we were talking about selectbox items, not about checkboxlist (and radiolist) labels.

[dg]

SelectBox::setItemAttribute and CheckboxList::setItemLabelAttribute (or attributes).

[matej21]

I've updated SelectBox and MultiSelectBox, but I think CheckboxList should have getItemLabelPrototype since the label is fully featured html element (it could have class, style...).

[dg]

• CheckboxList::$itemLabelPrototype is OK, it is consistent with RadioList.
• MultiSelectBox::setItemAttributes() is not actually set, but add. I don't know if it is better to set or add, but name must correspond with its functionality.
• what about 'option' instead of 'item'? Will be 'item' attributes used for optgroups?

[dg]

CheckboxList::$itemLabelPrototype was added here #92

[matej21]

Updated, failing tests are related to the nette/latte@b3b6a1d

[matej21]

rebased

[dg]

Merged e9849ef

[matej21]

thanks!