Skip to content

console: make console more standard compliant - #17708

Closed
BridgeAR wants to merge 3 commits into
nodejs:masterfrom
BridgeAR:console-standard
Closed

console: make console more standard compliant#17708
BridgeAR wants to merge 3 commits into
nodejs:masterfrom
BridgeAR:console-standard

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Dec 16, 2017

Copy link
Copy Markdown
Member

According to the standard the property descriptor of console
should be writable and non-enumerable.

Refs #12454
Fixes: #11805

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

console

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments
@Trott Trott Trott left review comments
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@targos targos targos approved these changes
+1 more reviewer
@apapirovski apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@BridgeAR @Trott @apapirovski @mcollina @bnoordhuis @jasnell @benjamingr @targos @nodejs-github-bot @Wandalen