inspector: roll inspector_protocol to match v8's - #56649
Closed
legendecas wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
legendecas
added
the
inspector
legendecas
marked this pull request as ready for review
January 17, 2025 23:58
legendecas
force-pushed
the
inspector/roll-protocol
branch
3 times, most recently
from
January 18, 2025 00:19
a9069ea to
be85fe3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56649 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.02%
==========================================
Files 662 663 +1
Lines 191945 192180 +235
Branches 36948 36988 +40
==========================================
+ Hits 171238 171425 +187
- Misses 13549 13573 +24
- Partials 7158 7182 +24
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Fix the inspector_protocol/roll.py to fit node source directory structure. `roll.py` reads the `deps/v8/thrid_party/inspector_protocol/README.v8` to get the revision of the inspector_protocol that V8 depends on, and updates the local version to match. V8's copy of inspector_protocol modifies the namespace of `crdtp` library and does not export the symbols. So it can not be used outside of V8.
legendecas
force-pushed
the
inspector/roll-protocol
branch
from
January 23, 2025 09:48
be85fe3 to
601a566
Compare
jasnell
approved these changes
Jan 23, 2025
github-actions
Bot
removed
the
request-ci
Collaborator
github-actions
Bot
removed
the
request-ci
Collaborator
Roll the inspector_protocol library to match V8's inspector_protocol revision. Update the node inspector to use the new `crdtp` protocol library.
The `crdtp` library in the inspector_protocol is compiled as a library and linked to the node executable.
legendecas
force-pushed
the
inspector/roll-protocol
branch
from
January 25, 2025 16:02
ab3d03c to
afcb230
Compare
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Member
Author
|
Fixed CI failures on AIX/linuxone. @nodejs/inspector would you mind taking another review? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools: update inspector_protocol roller
Fix the inspector_protocol/roll.py to fit node source directory
structure.
roll.pyreads thedeps/v8/thrid_party/inspector_protocol/README.v8to get the revision of the inspector_protocol that V8 depends on, and
updates the local version to match.
V8's copy of inspector_protocol modifies the namespace of
crdtplibrary and does not export the symbols. So it can not be used outside
of V8.
inspector: roll inspector_protocol
Roll the inspector_protocol library to match V8's inspector_protocol
revision.
Update the node inspector to use the new
crdtpprotocol library.deps: move inspector_protocol to deps
The
crdtplibrary in the inspector_protocol is compiled as a libraryand linked to the node executable.