Skip to content

Restrict LLVM inline asm location cookie usage. Fixes #150451 - #160197

Open
susitsm wants to merge 1 commit into
rust-lang:mainfrom
susitsm:restrict-inline-asm-cookies
Open

Restrict LLVM inline asm location cookie usage. Fixes #150451#160197
susitsm wants to merge 1 commit into
rust-lang:mainfrom
susitsm:restrict-inline-asm-cookies

Conversation

@susitsm

@susitsm susitsm commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The parallel frontend makes the cookies nondeterministic in their current form, resulting in nondeterministic outputs when bitcode is emitted or LTO is used.

Causes minor diagnostic regression for inline asm in release builds. See #150451 for details.

Fixes #150451

r? bjorn3

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2026
@rustbot

This comment has been minimized.

@susitsm
susitsm force-pushed the restrict-inline-asm-cookies branch 2 times, most recently from 1238b04 to e840de9 Compare July 30, 2026 06:49
@rust-log-analyzer

This comment has been minimized.

…O is enabled

The parallel frontend makes the cookies nondeterministic in their
current form, resulting in nondeterministic outputs when bitcode is
emitted or LTO is used.

Causes minor diagnostic regression for inline asm in release builds.
@susitsm
susitsm force-pushed the restrict-inline-asm-cookies branch from e840de9 to 4326f37 Compare July 30, 2026 07:21
@rustbot

rustbot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel compiler: threads::spawnning loop not reproducible

4 participants