Inline String::into_raw_parts and reuse from_utf16 optimization - #160536
Open
fereidani wants to merge 2 commits into
Open
Inline String::into_raw_parts and reuse from_utf16 optimization#160536fereidani wants to merge 2 commits into
String::into_raw_parts and reuse from_utf16 optimization#160536fereidani wants to merge 2 commits into
Conversation
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that comment
// This isn't done via collect::<Result<_, _>>() for performance reasons.explicitly states that this approach is wrong, butfrom_utf16leandfrom_utf16beare not using the same optimization.I believe
into_raw_partsis missing the#[inline]as any other similar functions in the standard library are marked either withinlineorinline(always).This is also related to #48994; whenever that fix lands, optimizing
from_utf16_unitswill results in these 3 functions getting optimized.