Skip to content

Inline String::into_raw_parts and reuse from_utf16 optimization - #160536

Open
fereidani wants to merge 2 commits into
rust-lang:mainfrom
fereidani:utf16_units
Open

Inline String::into_raw_parts and reuse from_utf16 optimization#160536
fereidani wants to merge 2 commits into
rust-lang:mainfrom
fereidani:utf16_units

Conversation

@fereidani

@fereidani fereidani commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  1. I noticed that comment // This isn't done via collect::<Result<_, _>>() for performance reasons. explicitly states that this approach is wrong, but from_utf16le and from_utf16be are not using the same optimization.

  2. I believe into_raw_parts is missing the #[inline] as any other similar functions in the standard library are marked either with inline or inline(always).

This is also related to #48994; whenever that fix lands, optimizing from_utf16_units will results in these 3 functions getting optimized.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2026
@rustbot

rustbot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 6 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants