Skip to content

Allow CodegenBackend to borrow from invoker of rustc_driver - #160624

Draft
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:borrowing_codegen
Draft

Allow CodegenBackend to borrow from invoker of rustc_driver#160624
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:borrowing_codegen

Conversation

@bjorn3

@bjorn3 bjorn3 commented Aug 6, 2026

Copy link
Copy Markdown
Member

I authored this change almost 6 years ago, but never had a good reason to submit it. I'm probably going to need it soon for some experiments on the cg_clif side, so I decided to upstream it now.

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2026
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@rust-log-analyzer

This comment has been minimized.

@bjorn3
bjorn3 marked this pull request as draft August 6, 2026 10:42
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
@bjorn3
bjorn3 force-pushed the borrowing_codegen branch from 0add3d0 to 4fe29d6 Compare August 6, 2026 10:43
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    |      ^^^^^^^^^^^^^^^^^^^^^^^ expected lifetime parameter
    |
help: indicate the anonymous lifetime
    |
115 | impl rustc_driver::Callbacks<'_> for DefaultCallbacks {}
    |                             ++++

error[E0726]: implicit elided lifetime not allowed here
   --> src/tools/clippy/src/driver.rs:123:6
    |
123 | impl rustc_driver::Callbacks for RustcCallbacks {
    |      ^^^^^^^^^^^^^^^^^^^^^^^ expected lifetime parameter
    |
help: indicate the anonymous lifetime
    |
123 | impl rustc_driver::Callbacks<'_> for RustcCallbacks {
    |                             ++++

error[E0726]: implicit elided lifetime not allowed here
   --> src/tools/clippy/src/driver.rs:137:6
    |
137 | impl rustc_driver::Callbacks for ClippyCallbacks {
    |      ^^^^^^^^^^^^^^^^^^^^^^^ expected lifetime parameter
    |
help: indicate the anonymous lifetime
    |
137 | impl rustc_driver::Callbacks<'_> for ClippyCallbacks {
    |                             ++++

[RUSTC-TIMING] lint_message_convention test:true 0.106
warning: hidden lifetime parameters in types are deprecated
   --> src/tools/clippy/src/driver.rs:124:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants