Ensure TLS accesses don't call the global allocator through panic (part 2) - #160976
Merged
rust-bors[bot] merged 1 commit intoAug 13, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
In #160934, I missed some calls that are reachable from
LocalKey::withon platforms that use the racyLazyKeyimplementation.How it didn't occur to me that the other functions (besides
getandset) are reachable is beyond me ^^I guess this is what I get for going through call graphs of disabled code by hand.
Yet another argument for function coloring.
r? nia-e