bake: contexts support with x-bake #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
reviewed
Aug 5, 2022
bake/compose.go
Outdated
| Pull *bool `yaml:"pull,omitempty"` | ||
| NoCache *bool `yaml:"no-cache,omitempty"` | ||
| NoCacheFilter stringArray `yaml:"no-cache-filter,omitempty"` | ||
| Contexts map[string]string `yaml:"contexts,omitempty"` |
Collaborator
There was a problem hiding this comment.
Not sure if we should call this stringMap for consistency? (even though the only reason we have stringArray is for the custom UnmarshalYAML case with CSV parsing).
Member
Author
There was a problem hiding this comment.
Good point to be consistent, I'm fine with it.
bake/compose.go
Outdated
| return strings.Join(bkattrs, ","), nil | ||
| } | ||
|
|
||
| func dedupMap(ms ...map[string]string) map[string]string { |
Collaborator
There was a problem hiding this comment.
We should put this next to dedupString - maybe in a separate file if they don't both fit in a single file neatly?
dedupString is a weird name as well for that now we'd have dedupMap, maybe we could change it to dedupSlice or equivalent?
Signed-off-by: CrazyMax <[email protected]>
jedevc
approved these changes
Aug 5, 2022
tonistiigi
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1107
Signed-off-by: CrazyMax [email protected]