[Carry #79] Change compose file handling to require valid service specifications #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the checks and some tests One of the tests wasn't valid docker-compose.yml, that's been changed. Bad config throws an error and has a test Signed-off-by: Jack Laxson <[email protected]>
Member
Member
|
/cc @dhiltgen |
… image fields Signed-off-by: Tibor Vass <[email protected]>
tonistiigi
approved these changes
May 30, 2019
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79 which is carried in this PR.
This PR basically handles properly compose services without a
buildfield, by skipping them, but errors out when neither abuildnor animagefield is present.Tests updated accordingly.