Add image mount options #5755
Merged
Add image mount options #5755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
image-mount-subpath
branch
3 times, most recently
from
5e1ea8d to
1baccee
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (14.58%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5755 +/- ##
==========================================
- Coverage 59.25% 59.18% -0.08%
==========================================
Files 352 352
Lines 29496 29544 +48
==========================================
+ Hits 17479 17486 +7
- Misses 11042 11078 +36
- Partials 975 980 +5 |
Signed-off-by: Laurent Goderre <[email protected]>
LaurentGoderre
force-pushed
the
image-mount-subpath
branch
from
1baccee to
04b1b4e
Compare
|
As a heads up, mounting with an image subpath doesn't survive a docker daemon restart currently (bug?): moby/moby#50999 -- crosslinking for visibility if others run into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add support for image mount options. Supports moby/moby#48798
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)