Skip to content

Conversation

@thaJeztah
Copy link
Member

cli/command/container: deprecate NewDiffFormat

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/container: DiffFormatWrite: remove intermediate var

Also rename "ctx" argument; we shouldn't use this as name for things
that are not a context.Context.

cli/command/container: newDiffContext: use struct-literal

cli/command/container: deprecate DiffFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

- Human readable description for the release notes

Go SDK: cli/command/container: deprecate `NewDiffFormat`, `DiffFormatWrite`. These functions were only used internally and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Also rename "ctx" argument; we shouldn't use this as name for things
that are not a context.Context.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 29.0.0 milestone Jul 16, 2025
@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Jul 16, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/container/formatter_diff.go 76.92% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah
Copy link
Member Author

Flaky test;

65.93 === Failed
65.93 === FAIL: cli/command/system TestSystemPrunePromptTermination (0.00s)
65.93     prune_test.go:80: assertion failed: error is "system prune has been cancelled" (system.cancelledErr), not "prompt terminated" (prompt.ErrTerminated prompt.cancelledErr)

@thaJeztah thaJeztah requested a review from Benehiko July 17, 2025 14:00
@thaJeztah thaJeztah merged commit 6cf2c02 into docker:master Jul 17, 2025
109 of 111 checks passed
@thaJeztah thaJeztah deleted the container_unexport branch July 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants