Skip to content

Conversation

@thaJeztah
Copy link
Member

These were deprecated in 6bd8a4b, and are no longer used.

- Human readable description for the release notes

Go SDK: cli: remove deprecated `VisitAll`, `DisableFlagsInUseLine` utilities.

- A picture of a cute animal (not mandatory but encouraged)

These were deprecated in 6bd8a4b, and
are no longer used.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 18, 2025
@thaJeztah thaJeztah added impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Aug 18, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vvoland
Copy link
Collaborator

vvoland commented Aug 18, 2025

We haven't had a release which includes the deprecation: #6273

Do we want to skip that and remove it without any deprecation period?

@austinvazquez
Copy link
Contributor

We haven't had a release which includes the deprecation: #6273

Do we want to skip that and remove it without any deprecation period?

I was thinking we can include them in 28.4 so the "next release" is 29, wdyt?

@thaJeztah
Copy link
Member Author

We haven't had a release which includes the deprecation: #6273
Do we want to skip that and remove it without any deprecation period?

I was thinking we can include them in 28.4 so the "next release" is 29, wdyt?

Yes, we've back ported that patch to the 28.x branch so that we can include it in 28.4;

Slightly fast-tracking these deprecations, although it's quite unlikely someone uses these, other than indirectly through the plugin initialisation which used it internally.

@vvoland vvoland merged commit 86e2a06 into docker:master Aug 20, 2025
105 checks passed
@thaJeztah thaJeztah deleted the cli_rm_deprecated_utils branch August 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants