Skip to content

Conversation

@Benehiko
Copy link
Member

This patch deprecates exported trust commands and moves the implementation details to an unexported function.

Commands that are affected include:

  • trust.NewTrustCommand

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/trust: deprecate `NewTrustCommand`. This function will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

This patch deprecates exported trust commands and moves the implementation
details to an unexported function.

Commands that are affected include:

- trust.NewTrustCommand

Signed-off-by: Alano Terblanche <[email protected]>
@Benehiko Benehiko added this to the 29.0.0 milestone Aug 20, 2025
@Benehiko Benehiko added impact/changelog impact/deprecation kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Aug 20, 2025
@Benehiko Benehiko enabled auto-merge August 20, 2025 12:09
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/trust/cmd.go 0.00% 9 Missing ⚠️
cli/command/commands/commands.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Benehiko Benehiko merged commit 4d93a64 into docker:master Aug 20, 2025
122 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants