Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 22, 2025

backport:

These functions and types were part of the presentation logic of the CLI and meant for internal use.


cli/command/container: deprecate NewDiffFormat

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/container: DiffFormatWrite: remove intermediate var

Also rename "ctx" argument; we shouldn't use this as name for things
that are not a context.Context.

cli/command/container: newDiffContext: use struct-literal

cli/command/container: deprecate DiffFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/network: deprecate NewFormat, FormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/image: deprecate NewHistoryFormat, HistoryWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/image: deprecate NewHistoryFormat, HistoryWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/checkpoint: deprecate NewFormat, FormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/config: deprecate NewFormat, FormatWrite, InspectFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/node: deprecate NewFormat, FormatWrite, InspectFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/plugin: deprecate NewFormat, FormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/registry: deprecate NewSearchFormat, SearchWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/secret: deprecate NewFormat, FormatWrite, InspectFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/service: deprecate NewFormat, InspectFormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/task: deprecate NewTaskFormat, FormatWrite

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

cli/command/trust: deprecate formatting-related functions and types

It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

This deprecates the following types and functions:

  • SignedTagInfo
  • SignerInfo
  • NewTrustTagFormat
  • NewSignerInfoFormat
  • TagWrite
  • SignerInfoWrite

- Human readable description for the release notes

Go SDK: cli/command/checkpoint: deprecate `NewFormat`, `FormatWrite`.
Go SDK: cli/command/config: deprecate `NewFormat`, `FormatWrite`, `InspectFormatWrite`.
Go SDK: cli/command/container: deprecate `NewDiffFormat`, `DiffFormatWrite`. These functions were only used internally and will be removed in the next release.
Go SDK: cli/command/image: deprecate `NewHistoryFormat`, `HistoryWrite`.
Go SDK: cli/command/image: deprecate `NewHistoryFormat`, `HistoryWrite`.
Go SDK: cli/command/network: deprecate `NewFormat`, `FormatWrite`.
Go SDK: cli/command/node: deprecate `NewFormat`, `FormatWrite`, `InspectFormatWrite`.
Go SDK: cli/command/plugin: deprecate `NewFormat`, `FormatWrite`.
Go SDK: cli/command/registry: deprecate `NewSearchFormat`, `SearchWrite`.
Go SDK: cli/command/secret: deprecate `NewFormat`, `FormatWrite`, `InspectFormatWrite`.
Go SDK: cli/command/service: deprecate `NewFormat`, `InspectFormatWrite`.
Go SDK: cli/command/task: deprecate `NewTaskFormat`, `FormatWrite`
Go SDK: cli/command/trust: deprecate `SignedTagInfo`, `SignerInfo`, `NewTrustTagFormat`, `NewSignerInfoFormat`, `TagWrite`, `SignerInfoWrite`.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.4.0 milestone Aug 22, 2025
@thaJeztah thaJeztah added impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Aug 22, 2025
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 907507e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Also rename "ctx" argument; we shouldn't use this as name for things
that are not a context.Context.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 239b727)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 0db7b9f)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit fdc90ca)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit e3903a1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 15cf4fa)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit d861b78)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit e626f77)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 123ef81)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit bf47419)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 83371c2)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit f3088e3)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 9f453d3)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit c3ee82f)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's part of the presentation logic of the cli, and only used internally.
We can consider providing utilities for these, but better as part of
separate packages.

This deprecates the following types and functions:

- `SignedTagInfo`
- `SignerInfo`
- `NewTrustTagFormat`
- `NewSignerInfoFormat`
- `TagWrite`
- `SignerInfoWrite`

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 95c9b1b)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the 28.x_backport_internalize_formatters branch from 54c2239 to 4133271 Compare August 22, 2025 09:48
@thaJeztah thaJeztah marked this pull request as ready for review August 22, 2025 09:48
@thaJeztah thaJeztah merged commit 0bbdda8 into docker:28.x Aug 22, 2025
100 of 101 checks passed
@thaJeztah thaJeztah deleted the 28.x_backport_internalize_formatters branch August 22, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants