Skip to content

Conversation

@thaJeztah
Copy link
Member

This patch deprecates exported NewPruneCommand and moves the implementation details to an unexported function.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/builder: deprecate `NewPruneCommand`.

- A picture of a cute animal (not mandatory but encouraged)

This patch deprecates exported NewPruneCommand and moves the
implementation details to an unexported function.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 22, 2025
@thaJeztah thaJeztah added impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK process/cherry-pick/28.x labels Aug 22, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/builder/prune.go 40.00% 3 Missing ⚠️
cli/command/builder/cmd.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many prune commands that were deprecated, was hard to keep track of them 🙈

@thaJeztah thaJeztah merged commit 832a375 into docker:master Aug 22, 2025
128 of 130 checks passed
@thaJeztah thaJeztah deleted the deprecate_builder_NewPruneCommand branch August 22, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants