Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 25, 2025


cli/command/config: remove deprecated types and functions

These were deprecated in a5f4ba0 and only
used internally.

This removes the deprecated types and functions:

  • RunConfigCreate and CreateOptions
  • RunConfigInspect and InspectOptions
  • RunConfigList and ListOptions
  • RunConfigRemove and RemoveOptions

- Human readable description for the release notes

Go SDK: cli/command/config: remove deprecated `RunConfigCreate`,  `CreateOptions`, `RunConfigInspect`, `InspectOptions`, `RunConfigList`, `ListOptions`, `RunConfigRemove`, and `RemoveOptions`.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 25, 2025
@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review area/swarm kind/refactor PR's that refactor, or clean-up code impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Aug 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ctalledo ctalledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ...

These were deprecated in a5f4ba0 and only
used internally.

This removes the deprecated types and functions:

- `RunConfigCreate` and  `CreateOptions`
- `RunConfigInspect` and `InspectOptions`
- `RunConfigList` and `ListOptions`
- `RunConfigRemove` and `RemoveOptions`

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the remove_exported_config_funcs branch from 8be798d to 250e4a5 Compare August 26, 2025 11:17
@thaJeztah thaJeztah marked this pull request as ready for review August 26, 2025 11:18
@thaJeztah thaJeztah requested a review from Benehiko August 26, 2025 11:18
@thaJeztah thaJeztah merged commit cfd7e54 into docker:master Aug 26, 2025
90 checks passed
@thaJeztah thaJeztah deleted the remove_exported_config_funcs branch August 26, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/swarm impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants