cli/command/stack: remove some deprecated functions #6398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were deprecated in f0e5a0d and d16c560 and were only used internally. Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were deprecated in f0e5a0d, 036d3a6, and d16c560 and were only used internally. Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were deprecated in f0e5a0d and 036d3a6 and were only used internally. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only used in a single place, and possibly incorrect. Let's inline it to put the logic where it's used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
area/stack
kind/refactor
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Benehiko
approved these changes
Aug 29, 2025
robmry
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/stack: remove deprecated RunList and options.List
These were deprecated in f0e5a0d and
d16c560 and were only used internally.
cli/command/stack: remove deprecated RunServices and swarm.GetServices
These were deprecated in f0e5a0d,
036d3a6, and
d16c560 and were only used internally.
cli/command/stack/swarm: remove deprecated RunPS and options.PS
These were deprecated in f0e5a0d and
036d3a6 and were only used internally.
cli/command/stack/swarm: inline validateResolveImageFlag
It was only used in a single place, and possibly incorrect. Let's inline
it to put the logic where it's used.
cli/command/stack/swarm: deployServices: use struct-literal for options
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)