cli-plugins/manager: remove deprecated types, functions and aliases #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors satisfy errdefs.IsNotFound, which can be used instead. This function was deprecated in 7146021 and is no longer used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
These consts and types were moved to a separate metadata package in commits 292713c and 4321293, and deprecated in 72f76f2, 5876b29, and 6fa7d18. This removes the deprecated aliases in `cli-plugins/manager` in favor of their equivalent in `cli-plugins/manager/metadata`: - `CommandAnnotationPlugin` - `CommandAnnotationPluginVendor` - `CommandAnnotationPluginVersion` - `CommandAnnotationPluginInvalid` - `CommandAnnotationPluginCommandPath` - `NamePrefix` - `MetadataSubcommandName` - `HookSubcommandName` - `Metadata` - `ReexecEnvvar` Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
area/plugins
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vvoland
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
cli-plugins/manager: remove deprecated IsNotFound
These errors satisfy errdefs.IsNotFound, which can be used instead. This
function was deprecated in 7146021 and
is no longer used.
cli-plugins/manager: remove deprecated metadata aliases
These consts and types were moved to a separate metadata package in commits
292713c and 4321293,
and deprecated in 72f76f2, 5876b29,
and 6fa7d18.
This removes the deprecated aliases in
cli-plugins/managerin favor oftheir equivalent in
cli-plugins/manager/metadata:CommandAnnotationPluginCommandAnnotationPluginVendorCommandAnnotationPluginVersionCommandAnnotationPluginInvalidCommandAnnotationPluginCommandPathNamePrefixMetadataSubcommandNameHookSubcommandNameMetadataReexecEnvvar- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)