remove DOCKER_CLI_DISABLE_OAUTH_LOGIN escape hatch #6463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This const was added in 846ecf5, but only used internally; commit 18cdc25 deprecated the const, which was included in the 28.4 release. This patch removes the exported const, as it's unused. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This code was added in 846ecf5 as an escape hatch in case the new OAuth login flow would cause problems. We have not received reports where the new flow caused problems, and searching the internet shows no mentions of the env-var. This env-var was not documented, so we can remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_oauth_escape_hatch
branch
from
2bcf42d to
71f4605
Compare
vvoland
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
cli/command/registry: remove deprecated OauthLoginEscapeHatchEnvVar
This const was added in 846ecf5, but
only used internally; commit 18cdc25
deprecated the const, which was included in the 28.4 release.
This patch removes the exported const, as it's unused.
remove DOCKER_CLI_DISABLE_OAUTH_LOGIN escape hatch
This code was added in 846ecf5 as an
escape hatch in case the new OAuth login flow would cause problems.
We have not received reports where the new flow caused problems, and
searching the internet shows no mentions of the env-var.
This env-var was not documented, so we can remove it.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)