Skip to content

Conversation

@thaJeztah
Copy link
Member

These options were used internally as defaults for the constructor and only impact commands implemented in the CLI itself.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command: deprecate `WithContentTrustFromEnv`, `WithContentTrust` options. These options were used internally, and will be removed in the next release..

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.5.0 milestone Sep 25, 2025
@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review area/trust kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Sep 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/cli_options.go 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the 28.x_backport_deprecate_dct_opts branch from 9ea6364 to 08065fc Compare September 25, 2025 07:58
These options were used internally as defaults for the constructor and
only impact commands implemented in the CLI itself.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 40cdfc0)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the 28.x_backport_deprecate_dct_opts branch from 08065fc to 4665091 Compare September 25, 2025 10:52
@vvoland vvoland merged commit bea31fc into docker:28.x Sep 25, 2025
92 of 93 checks passed
@thaJeztah thaJeztah deleted the 28.x_backport_deprecate_dct_opts branch September 25, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK area/trust impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants