Skip to content

Move FlTextInputHandler from FlView #162131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 13, 2025
Merged

Move FlTextInputHandler from FlView #162131

auto-submit merged 2 commits into from
Feb 13, 2025

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jan 24, 2025

This moves the final part of the keyboard handling from FlView to the FlEngine and means keyboard should work correctly with multiple views.

@robert-ancell
Move FlTextInputHandler from FlView
10b1408 
This moves the final part of the keyboard handling from FlView to the FlEngine
and means keyboard should work correctly with multiple views.
@robert-ancell
Fix mock classes being accessed after destructions
416053d
@robert-ancell robert-ancell requested a review from mattkae January 24, 2025 02:03
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Jan 24, 2025
mattkae
mattkae approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@mattkae mattkae enabled auto-merge January 24, 2025 14:16
@robert-ancell
Copy link
Contributor Author

robert-ancell commented Jan 26, 2025

@cbracken since this touches the IM code are you able to validate everything is still working?

@chinmaygarde
Copy link
Member

chinmaygarde commented Feb 3, 2025

Ping @cbracken

@robert-ancell robert-ancell mentioned this pull request Feb 13, 2025
Merged
@robert-ancell
Copy link
Contributor Author

robert-ancell commented Feb 13, 2025

Not able to be reviewed by @cbracken soon, so will land this now.

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into flutter:master with commit 4cc9db4 Feb 13, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
2f11953
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
ce4add5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
e941b74
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
d2003df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
f0f059f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
dadd112
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
d8959f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
d245246
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
c3bc699
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
625f48b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
ff5c311
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
ed24446
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
0f4b322
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
a4140b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
47d5872
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
8ee2e1b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
1356670
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
9946c6a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
b069f70
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
d353f2b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
b948492
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
b396a65
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
fd15f92
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
a10845b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
aae72ba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
23c7016
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
356c040
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
4cc9db4 Move FlTextInputHandler from FlView (flutter/flutter#162131)
bbc67f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robert-ancell @chinmaygarde @mattkae