-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 (chore): avoid shadowing of 'err' in plugin util and test utilities #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (chore): avoid shadowing of 'err' in plugin util and test utilities #4654
Conversation
|
Hi @kersten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kersten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replaced short variable declarations with assignments in pkg/plugin/util/util.go and util_test.go to avoid shadowing the existing 'err' variable. This ensures proper error propagation, improves code readability, and aligns with Go best practices for error handling and scope control.
c32e102 to
6f38d5f
Compare
|
/lgtm |
Replaced short variable declarations with assignments in
pkg/plugin/util/util.goandutil_test.goto avoid shadowing the existingerrvariable. This ensures proper error propagation, improves code readability, and aligns with Go best practices for error handling and scope control.