This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Resolves two issues with term creation and term assocaition#1430
Merged
rmccue merged 3 commits intoWP-API:developfrom Aug 7, 2015
Merged
Resolves two issues with term creation and term assocaition#1430rmccue merged 3 commits intoWP-API:developfrom
rmccue merged 3 commits intoWP-API:developfrom
Conversation
…m_taxonomy_id with WP core's use of term_id.
… of the term_taxonomy_id, not the term_id. The term_id is useless to the client.
Member
|
Thanks for the pull request! Good catch on the issue! The tests are currently failing here due to your code not matching the WP coding standards. Can you fix these up please? :) |
Contributor
Author
|
All set. Would you mind re-opening #1395 until this is resolved so that other folks experiencing the same problem might find the solution? |
Member
|
This is missing a bit of test coverage on the new lines, but I'm not sure there's a way to test this with the latest versions of WP, since IIRC they don't let you create a term where With that considered, merging. Thanks for the PR! |
rmccue
added a commit
that referenced
this pull request
Aug 7, 2015
Resolves two issues with term creation and term assocaition
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
term_taxonomy_idas part of the error data, NOT theterm_id. Theterm_idis useless and arguably dangerous to the client, since they may attempt to use it elsewhere (ahem ;)).term_idfrom the client-providedterm_taxonomy_id. Wordpress core uses theterm_idto make the association.