Refactor archive file handling in file.php#10618
Closed
roborourke wants to merge 1 commit intoWordPress:trunkfrom
Closed
Refactor archive file handling in file.php#10618roborourke wants to merge 1 commit intoWordPress:trunkfrom
roborourke wants to merge 1 commit intoWordPress:trunkfrom
Conversation
The foreach loops set the $file variable, overriding the one passed into the function on each iteration, so the filter does not work as documented for `_unzip_file_pclzip()`
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
@roborourke looks like the changes broke a related unit test. |
| // Extract the files from the zip. | ||
| foreach ( $archive_files as $file ) { | ||
| foreach ( $archive_files as $archive_file ) { | ||
| if ( $file['folder'] ) { |
Member
There was a problem hiding this comment.
Suggested change
| if ( $file['folder'] ) { | |
| if ( $archive_file['folder'] ) { |
Missing instance of old variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreach loops set the $file variable, overriding the one passed into the function on each iteration, so the filter does not work as documented for
_unzip_file_pclzip()Uses a different variable name in the
foreachloops to preserve the$filevariable passed to the filter.Trac ticket: https://core.trac.wordpress.org/ticket/64398
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.