Skip to content

Fix up linting, make lint clean#10

Closed
jakebailey wants to merge 1 commit intotransform-stack-commit-9from
transform-stack-commit-10
Closed

Fix up linting, make lint clean#10
jakebailey wants to merge 1 commit intotransform-stack-commit-9from
transform-stack-commit-10

Conversation

@jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 31, 2022 •
edited
Loading

Now that we are modules, there's no reason to ban multiple namespaces
per file; each file is its own scope and declaring a namespace won't
merge it into any other files.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean (this PR)
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 862b53a to b303800 Compare June 1, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from de15745 to 21d2bb9 Compare June 1, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from b303800 to a9b1b81 Compare July 26, 2022 23:06
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch 5 times, most recently from 447b364 to 4be74e4 Compare August 29, 2022 23:17
@jakebailey jakebailey changed the title Bad attempt to solve some cycles (not complete) Get test suites running Aug 29, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 21d2bb9 to dd3abe2 Compare August 29, 2022 23:17
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 4be74e4 to 0bdfaab Compare August 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from dd3abe2 to 8d3b866 Compare August 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 0bdfaab to ed1fa01 Compare September 3, 2022 04:21
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 8d3b866 to ec3de2a Compare September 3, 2022 04:21
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from ed1fa01 to 719036a Compare September 3, 2022 04:43
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from ec3de2a to ce5df67 Compare September 3, 2022 04:43
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 719036a to 626c88b Compare September 7, 2022 22:31
@jakebailey jakebailey changed the title Get test suites running Convert require calls to imports Sep 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from ce5df67 to d40d483 Compare September 7, 2022 22:31
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 626c88b to 44fab70 Compare September 13, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from d40d483 to b576e05 Compare September 13, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 44fab70 to 53c4f2c Compare September 13, 2022 20:27
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from b576e05 to 529ac2b Compare September 13, 2022 20:27
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 53c4f2c to bb30e75 Compare September 13, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 529ac2b to 3460bfe Compare September 13, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from bb30e75 to 804627b Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 3460bfe to 7f20686 Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 804627b to 3cbc760 Compare September 13, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 7f20686 to 6854688 Compare September 13, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 3cbc760 to 197b5d4 Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 521fbd5 to 384138c Compare September 19, 2022 20:37
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from b83d2c7 to 8987a2b Compare September 19, 2022 20:37
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 384138c to 833817e Compare September 20, 2022 05:05
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 8987a2b to eeaeb48 Compare September 20, 2022 05:05
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 833817e to 600071d Compare September 20, 2022 05:10
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from eeaeb48 to 9c8a095 Compare September 20, 2022 05:10
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 600071d to 21b899d Compare September 20, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 9c8a095 to 378f0a2 Compare September 20, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 21b899d to 2d2bc32 Compare September 24, 2022 16:50
@jakebailey jakebailey changed the title Convert require calls to imports Add JSDoc eslint rule Sep 24, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 378f0a2 to bc19be8 Compare September 24, 2022 16:50
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 2d2bc32 to b13c24e Compare September 26, 2022 23:09
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from bc19be8 to d4e1158 Compare September 26, 2022 23:09
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from b13c24e to 14edf84 Compare September 27, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from d4e1158 to 3452995 Compare September 27, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 14edf84 to c715b6f Compare September 28, 2022 00:36
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 3452995 to 4a32b3c Compare September 28, 2022 00:36
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from c715b6f to 338eb4b Compare September 28, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 4a32b3c to 07e9212 Compare September 28, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 338eb4b to c5d4e71 Compare September 28, 2022 05:03
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 07e9212 to c37eb63 Compare September 28, 2022 05:03
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from c5d4e71 to e2e794a Compare September 28, 2022 07:45
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from c37eb63 to 55c7a4b Compare September 28, 2022 07:45
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from e2e794a to c051a97 Compare September 28, 2022 19:39
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 55c7a4b to a221932 Compare September 28, 2022 19:39
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from c051a97 to 34f469f Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from a221932 to faf17aa Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 34f469f to 539021a Compare October 3, 2022 21:40
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from faf17aa to cd3a89e Compare October 3, 2022 21:40
@jakebailey
Fix up linting, make lint clean
9ff5d03 
Now that we are modules, there's no reason to ban multiple namespaces
per file; each file is its own scope and declaring a namespace won't
merge it into any other files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakebailey