Skip to content

Made Printer::printAttributes protected (was private) #123

Closed
Aterlupus wants to merge 10 commits intonette:masterfrom
Aterlupus:master
Closed

Made Printer::printAttributes protected (was private) #123
Aterlupus wants to merge 10 commits intonette:masterfrom
Aterlupus:master

Conversation

@Aterlupus
Copy link
Copy Markdown

Made Printer::printAttributes protected (was private) to enable possibility of changing its behavior by user (open-closed principle)

  • bug fix - since Printer is designed to be extended for modified behavior and "private" accessor made that harder
  • BC break? - no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants