Skip to content

repl: fix terminal default setting and improve color check#26518

Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:improve-repl-color-check
Closed

repl: fix terminal default setting and improve color check#26518
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:improve-repl-color-check

Conversation

@BridgeAR
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR commented Mar 8, 2019

This makes sure that the described default behavior for the
terminal option is actually always used and not only when running
the REPL as standalone program.

The color detection is also improved by checking for hasColors()
if possible.

I also moved a few lines so that the code is logically combined instead of being spread out in the big REPL constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants