repl: fix terminal default setting and improve color check#26518
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
repl: fix terminal default setting and improve color check#26518BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the described default behavior for the
terminaloption is actually always used and not only when runningthe REPL as standalone program.
The color detection is also improved by checking for
hasColors()if possible.
I also moved a few lines so that the code is logically combined instead of being spread out in the big REPL constructor.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes