Skip to content

stream: simpler Readable async iterator#34035

Closed
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:readable-async-iterator
Closed

stream: simpler Readable async iterator#34035
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:readable-async-iterator

Conversation

@ronag
Copy link
Copy Markdown
Member

@ronag ronag commented Jun 23, 2020 •
edited
Loading

Simplifies async iteration for Readable using async generator.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott left review comments

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

+2 more reviewers

@devsnek devsnek devsnek left review comments

@lundibundi lundibundi lundibundi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ronag @nodejs-github-bot @mcollina @benjamingr @jasnell @Trott @devsnek @lundibundi @targos