Skip to content

child_process: add AbortSignal support#36308

Closed
benjamingr wants to merge 1 commit intonodejs:masterfrom
benjamingr:child-process-abort-signal
Closed

child_process: add AbortSignal support#36308
benjamingr wants to merge 1 commit intonodejs:masterfrom
benjamingr:child-process-abort-signal

Conversation

@benjamingr
Copy link
Copy Markdown
Member

@benjamingr benjamingr commented Nov 28, 2020

Support AbortSignal in child_process.execFile.

Bikeshedding:

  • I know everywhere else it's called signal and that it's the web platform guidance - but I think we might want to deviate here and call the parameter abortSignal to prevent confusion with OS signals and killSignal. WDYT?

I will follow up with support in the other child_process APIs like fork and spawn.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants