module: open stat/readPackage to mutations#44537
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Sep 18, 2022
Merged
module: open stat/readPackage to mutations#44537nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the CJS loader uses the
fsmodule to perform most filesystem I/O, it uses two hidden internal primitives for speed:internalModuleStat, andpackageJsonReader. BecauseinternalModuleStatis destructured, it cannot be replaced. As a result, tools that experiment with virtual filesystem layers have to reimplement the whole CJS resolution stack. This is problematic because we want to experiment writing VFS with https://github.com/nodejs/single-executable.This diff aims to provide a way for advanced tooling authors to avoid having to hijack the full resolution (which is much more invasive and dangerous than what this diff allows), while still respecting the wish for speed from Node (ie we're not suggesting to stop using the special internal primitives, but just to expose them the same way we already expose
Module._findPathsorModule._resolveFilename).