lib,test: fix bug in InternalSocketAddress#44618
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 15, 2022
Merged
lib,test: fix bug in InternalSocketAddress#44618nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalSocketAddressmust set[kDetails]in order for the inherited properties to function correctly.Cherry-picked from @jasnell's #44325 in order to make the QUIC PR simpler to review (with his permission). This change makes sense even without the QUIC PR.
I added a test case for
InternalSocketAddresstotest-socketaddress.js, which is not part of the original commit.