test_runner: handled change for exposing 'spec' reporter#48202
Closed
Sumi0 wants to merge 3 commits intonodejs:mainfrom
Closed
test_runner: handled change for exposing 'spec' reporter#48202Sumi0 wants to merge 3 commits intonodejs:mainfrom
Sumi0 wants to merge 3 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Issue#48112
Other reporters (dot, tap) by signature are a function while 'spec'
reporter is a ES6 class.
This behaviour of api spec is causing difference in semantics while
consumption since it has not been addressed anywhere in the document
(it has to be instantiated).
Instead of making changes in the signature of spec.js, i have proposed
changes where the 'spec' reporter gets exposed in reporter.js
Refs: reporter/spec.js
Refs: (@line-no:143) test_runner/utils.js