Skip to content

fs: unexpose internal constants#58327

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:constants/internal
May 16, 2025
Merged

fs: unexpose internal constants#58327
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:constants/internal

Conversation

@legendecas
Copy link
Copy Markdown
Member

EXTENSIONLESS_FORMAT_JAVASCRIPT and EXTENSIONLESS_FORMAT_WASM are
only used internally through binding getFormatOfExtensionlessFile.
They should not be exposed publicly.

Add a test to cover public fs.constants to avoid unexpected keys.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants