Skip to content

[v24.x] deps: V8: backport 1c3e018e7d48#58818

Closed
Renegade334 wants to merge 1 commit intonodejs:v24.x-stagingfrom
Renegade334:v8-backport-api-dispose-symbols
Closed

[v24.x] deps: V8: backport 1c3e018e7d48#58818
Renegade334 wants to merge 1 commit intonodejs:v24.x-stagingfrom
Renegade334:v8-backport-api-dispose-symbols

Conversation

@Renegade334
Copy link
Copy Markdown
Member

This backport from 13.7 facilitates defining ERM disposal methods within the C++ layer.

Original commit message:

Expose dispose and asyncDispose symbols to C++

Since `Symbol.dispose` has been exposed to JS we need to be able to
access the native v8::Symbol too.

Change-Id: I9111d2806630efdd8bb5f931effa9adad3c85ae5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6410112
Commit-Queue: Erik Corry <erikcorry@chromium.org>
Reviewed-by: Erik Corry <erikcorry@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99590}

refs: v8/v8@1c3e018

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants