crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4#58942
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Jul 5, 2025
Merged
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4#58942nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
This PR:
crypto.createHash().update().digest()until crypto: support outputLength option in crypto.hash for XOF functions #58121 gets on trackAfter this lands a semver-majorPRs that contain breaking changes and should be released in the next major version.
will follow with a runtime deprecation.
This will need backporting all the way back to 20.x
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
Note: FWIW #56160 should not have landed. Any OpenSSL version-related test changes should only accomodate changes in codes, not behaviour.