Skip to content

benchmark: calibrate length of util.diff#59588

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RafaelGSS:calibrate-util-diff
Aug 24, 2025
Merged

benchmark: calibrate length of util.diff#59588
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RafaelGSS:calibrate-util-diff

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

@RafaelGSS RafaelGSS commented Aug 22, 2025

benchmark: calibrate length of util.diff

500 + 1000 already covers the curve. 2000 doesn’t add new qualitative insight — it just extends the same curve further down (another ~3–4× slowdown).

According to https://github.com/nodejs/performance/issues/186 this benchmark takes one minute to conclude a single run. This should fix it.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

+1 more reviewer

@Uzlopak Uzlopak Uzlopak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS @nodejs-github-bot @lpinca @Uzlopak @atlowChemi