fix: npm link <pkg> should not save package.json#2245
Closed
ruyadorno wants to merge 1 commit intonpm:latestfrom
Closed
fix: npm link <pkg> should not save package.json#2245ruyadorno wants to merge 1 commit intonpm:latestfrom
ruyadorno wants to merge 1 commit intonpm:latestfrom
Conversation
ruyadorno
added
Release 7.x
ljharb
reviewed
Nov 27, 2020
Contributor
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
However, if save/save/dev/save-peer is explicitly provided, it should save it. Does it with this PR?
When running `npm link <pkg>` it should not save the new item to the currrent dependencies of that package.json file. Fixes: npm#2034 Co-authored-by: Darcy Clarke <darcy@darcyclarke.me>
ruyadorno
force-pushed
the
fix-npm-link-no-save
branch
from
719f7ef to
51d4666
Compare
Contributor
|
@ljharb fixed this up so |
darcyclarke
approved these changes
Nov 27, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
npm link <pkg>it should not save the new item to thecurrrent dependencies of that package.json file.
Fixes: #2034